remove misleading sentence about incompatible QUIC versions and ALPN #2802
Conversation
| @@ -1279,8 +1279,7 @@ An application-layer protocol MAY restrict the QUIC versions that it can operate | |||
| over. Servers MUST select an application protocol compatible with the QUIC | |||
There was a problem hiding this comment.
Plural singular mix: Servers vs the server. Perhaps use "a server"?
There was a problem hiding this comment.
Not part of this PR.
|
@martinthomson That depends on how you read RFC 7301, doesn't it? Section 3.1 says:
I interpret "suitable" as "one of the options that the client proposed", but unfortunately that RFC is not very specific. |
|
That is confusing, but it doesn't mean that the server doesn't pick an ALPN. We do require that it select an ALPN value, and even if it picks one that the client doesn't offer (whether legitimate or not), that doesn't invalidate this text. |
| @@ -1279,8 +1279,7 @@ An application-layer protocol MAY restrict the QUIC versions that it can operate | |||
| over. Servers MUST select an application protocol compatible with the QUIC | |||
| version that the client has selected. If the server cannot select a compatible | |||
| combination of application protocol and QUIC version, it MUST abort the | |||
| connection. A client MUST abort a connection if the server picks an incompatible | |||
| combination of QUIC version and ALPN identifier. | |||
There was a problem hiding this comment.
This requirement is still true. If you object to the implication of the server picking a version, maybe this should be "A client MUST abort a connection if the server picks an application protocol incompatible with the protocol version being used."?
There was a problem hiding this comment.
I like that one. Just updated the PR.
|
No, I was suggesting restoring the sentence that was there before, but with alternate wording to address @marten-seemann's concern. Now the server MUST abort if it can't pick a proper combination, and the client MUST abort if the server fails to abide by that requirement. |
martinthomson
added
the
editorial
The server doesn't pick a version. The server only picks the application protocol from what the client offered, and it might do that based on the QUIC version that the client picked.